Implement ICloneableFormat #168
Conversation
src/Yarhl/IO/BinaryFormat.cs
Outdated
| @@ -93,6 +94,15 @@ public BinaryFormat(Stream stream, long offset, long length) | |||
| private set; | |||
| } | |||
|
|
|||
| /// <inheritdoc /> | |||
There was a problem hiding this comment.
Can you add in the remarks of the documentation of this method that it creates the copy in memory (good to know for large streams).
| /// <param name="node">The original node.</param> | ||
| /// <remarks><para>It makes a copy of the original node. | ||
| /// The original format is deep copied. See <see cref="ICloneableFormat"/> for details.</para></remarks> | ||
| public Node(Node node) |
There was a problem hiding this comment.
Should we copy add or copy recursively the children?
If not, I think we should specify the behavior in the remarks of the doc.
There was a problem hiding this comment.
The children are already copied recursively because NodeContainerFormat implements DeepClone() and there is where the copies are made.
I'll add the comment in case the node has children but its format is not NodeContainerFormat.
| var newFormat = new NodeContainerFormat(); | ||
|
|
||
| // Just copy the first generation children. | ||
| // The rest will be copied recursively if necessary. |
There was a problem hiding this comment.
Right now the constructor of Node is not copying the nodes, is this comment still accurate? How would the node be copied recursively otherwise?
| Assert.AreNotSame(format, clone); | ||
| Assert.AreNotSame(child1, child1Clone); | ||
| Assert.AreNotSame(child2, child2Clone); | ||
| Assert.AreNotSame(grandchild, grandchildClone); |
There was a problem hiding this comment.
Maybe this is passing because grandchildClone is null? I think the copy is not recursively.
There was a problem hiding this comment.
No, grandchildClone has contents:
Description
In this PR,
BinaryFormat,NodeContainerFormatandPoclasses implement aICloneableFormatinterface, making easier to get duplicates.Also, there is a new constructor in
Nodethat accepts other node. It makes a new node with the same name and tags than the original node and a deep copy of its format.Example