New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ICloneableFormat #168
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// Copyright (c) 2019 SceneGate | ||
|
||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
|
||
// The above copyright notice and this permission notice shall be included in all | ||
// copies or substantial portions of the Software. | ||
|
||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
// SOFTWARE. | ||
namespace Yarhl.FileFormat | ||
{ | ||
/// <summary> | ||
/// Cloneable format interface. | ||
/// </summary> | ||
public interface ICloneableFormat : IFormat | ||
{ | ||
/// <summary> | ||
/// Deep clones a format into a new object. | ||
/// </summary> | ||
/// <returns>The cloned format.</returns> | ||
/// <remarks> | ||
/// <para>A 'deep copy' must create the necessary copies, in the way that | ||
/// any change in the original node (or any of it's member hierarchy) won't affect | ||
/// the cloned node.</para> | ||
/// </remarks> | ||
object DeepClone(); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ | |
namespace Yarhl.FileSystem | ||
{ | ||
using System; | ||
using System.Collections.Generic; | ||
using Yarhl.FileFormat; | ||
using Yarhl.IO; | ||
|
||
|
@@ -48,6 +49,36 @@ public Node(string name, IFormat initialFormat) | |
ChangeFormat(initialFormat); | ||
} | ||
|
||
/// <summary> | ||
/// Initializes a new instance of the <see cref="Node"/> class. | ||
/// </summary> | ||
/// <param name="node">The original node.</param> | ||
/// <remarks><para>It makes a copy of the original node. | ||
/// The original format is deep copied. See <see cref="ICloneableFormat"/> for details.</para> | ||
/// </remarks> | ||
/// <remarks><para>If the node has children, it must be a <see cref="NodeContainerFormat"/> to clone them. | ||
/// In other case, the format must implement <see cref="ICloneableFormat"/> and clone the children explicitly. | ||
/// </para></remarks> | ||
public Node(Node node) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we copy add or copy recursively the children? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The children are already copied recursively because |
||
: this(node != null ? node.Name : string.Empty) | ||
{ | ||
if (node!.Format != null && !(node.Format is ICloneableFormat)) | ||
throw new InvalidOperationException("Format does not implement ICloneableFormat interface."); | ||
|
||
ICloneableFormat newFormat = null; | ||
if (node.Format != null) { | ||
var oldFormat = node.Format as ICloneableFormat; | ||
newFormat = (ICloneableFormat)oldFormat!.DeepClone(); | ||
} | ||
|
||
ChangeFormat(newFormat); | ||
|
||
foreach (KeyValuePair<string, dynamic> tag in node.Tags) | ||
{ | ||
Tags[tag.Key] = tag.Value; | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Gets the current format of the node. | ||
/// </summary> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is passing because
grandchildClone
isnull
? I think the copy is not recursively.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
grandchildClone
has contents: