-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonscalar resolver and hook arguments #140
Comments
@theseanything any thoughts on this feature? Anything I can help implement? |
Hi @sftrabbit - great issue and nice PR. Unfortunately, Sceptre has changed quite a bit. If this is still something you would like to see then you may need to redo the implementation of this 🙏 |
ngfgrant
pushed a commit
that referenced
this issue
Dec 8, 2018
Resolved by #473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
YAML's tag syntax supports nonscalar tag arguments, such as lists or mappings (or even other tags). For example:
However, Sceptre doesn't allow this for the arguments of resolvers and hooks. The resolver and hook constructors added to the YAML loader assume a scalar argument when calling
loader.construct_scalar(node)
(for both resolvers and hooks).It would be useful to support nonscalar arguments for both resolvers and hooks for more configurable cases such as something like this:
(Note the nested resolver! That's a bonus!)
There's a few ways to work around this at the moment, such as by passing things through
sceptre_user_data
or by passing strings that you parse into multiple arguments, but they typically result in some shenanigans involving using sceptre internals. Nonscalar arguments would be very neat and tidy!PR incoming...
The text was updated successfully, but these errors were encountered: