Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resolve #140]: for V1: Nonscalar arguments for hooks and resolvers. #473

Merged
merged 4 commits into from
Dec 8, 2018
Merged

[Resolve #140]: for V1: Nonscalar arguments for hooks and resolvers. #473

merged 4 commits into from
Dec 8, 2018

Conversation

akdor1154
Copy link
Contributor

@akdor1154 akdor1154 commented Sep 20, 2018 •
edited
Loading

Rebase of #141 . See original by @sftrabbit for details.

@akdor1154
Copy link
Contributor Author

The one hesitation in the original PR was that nested stack_outputs add dependencies to their owning stacks properly; I've added a test to ensure this functions appropriately (no code changes were needed).

@akdor1154 akdor1154 force-pushed the 140-non-scalar-resolvers-and-hooks branch from efb4f59 to 50b0660 Compare September 20, 2018 07:57
@ngfgrant
Copy link
Contributor

@akdor1154 can you get this rebased on v1 and I will get it merged next. Should be in for the next v1 release.

@akdor1154 akdor1154 force-pushed the 140-non-scalar-resolvers-and-hooks branch from 50b0660 to 44131bf Compare October 31, 2018 22:39
@akdor1154 akdor1154 force-pushed the 140-non-scalar-resolvers-and-hooks branch from 44131bf to 84694fb Compare October 31, 2018 22:43
@akdor1154
Copy link
Contributor Author

should be good to go

@ngfgrant ngfgrant changed the base branch from v1 to v1.5.0beta December 8, 2018 14:14
@ngfgrant ngfgrant merged commit ed681aa into Sceptre:v1.5.0beta Dec 8, 2018
@ngfgrant ngfgrant mentioned this pull request Dec 9, 2018
Closed
ngfgrant pushed a commit that referenced this pull request May 9, 2019
@akdor1154 @ngfgrant
[Resolve #140] Nonscalar arguments for hooks and resolvers (v1). (#473)
827e8af 
* Reorder Resolver and ResolvableProperty

* Add support for nonscalar arguments to resolvers and hooks

* add a test to ensure nested stack_output gives a dependency properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akdor1154 @ngfgrant @sftrabbit