You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have noticed that when my auth token expires, e.g.
# aws s3 ls
An error occurred (ExpiredToken) when calling the AssumeRole operation: The security token included in the request is expired
Some Sceptre commands such as list outputs eat this and fail silently. Others don't. For example:
# sceptre --merge-vars --dir=network --var-file=/app/platform-sceptre/stacks/../data/test/common-env.yaml --var-file=/app/platform-sceptre/stacks/../data/test/network-e2e.yaml launch network.yaml -y
[2024-03-23 10:08:08] - vpc - Launching Stack
"An error occurred (ExpiredToken) when calling the AssumeRole operation: The security token included in the request is expired"
This resolves a bug in `sceptre outputs` where all `ClientError`
exceptions (e.g. `ExpiredToken`) are suppressed, for no apparent reason.
In 682a306, (October 2018, commit
summary "Move Stack operations from Stack to StackActions"), a big
refactor had occurred. That refactor had introduced a public method
`describe` in the `StackActions` class.
A month later, in 182f0b6 (November 2018,
commit summary "Implement algorithm to execute Stacks from StackGraph"),
another big refactor occurred. A part of that refactor was to introduce an
essentially duplicate method `_describe` and then in the
`describe_output` method, catch all `ClientError` exceptions and always
return an empty list.
So far as I can tell, there was no good reason to introduce either the
new method, or catch all `ClientError` exceptions. The suppression of
exceptions may have been accidental, or a hack to get the unit tests to
pass.
This patch attempts to fix all of this up:
- Duplicate method removed in favour of the public `describe` method. I
have opted to keep the public method as the differ class is calling,
making it public.
- The change to `describe_outputs` is reverted.
- The unit tests are rewritten.
Subject of the issue
I have noticed that when my auth token expires, e.g.
Some Sceptre commands such as
list outputs
eat this and fail silently. Others don't. For example:Compared to
Your environment
Steps to reproduce
See above.
Expected behaviour
Should see that the token expired.
Actual behaviour
No output.
The text was updated successfully, but these errors were encountered: