Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with glibc-2.16 #22

Closed
wants to merge 1 commit into from
Closed

Conversation

Xarthisius
Copy link
Contributor

Due to yet another change in header files made by glibc's maintainers <sys/resource.h> is required in couple of places.
For build failure with slurm-2.3.4 please see: http://tinyurl.com/c5fuvsg
Downstream bug report: https://bugs.gentoo.org/show_bug.cgi?id=430252

@dannyauble
Copy link
Member

This patch doesn't appear to modify anything in src/common/jobacct_common.c (which doesn't exist anymore -> src/common/slurm_jobacct_gather.c) Not sure how this could fix the build error. It appears adding a #include <sys/wait.h> should fix this build error though. Can you please verify this issue with 2.4 or 2.5?

There will be no more 2.3 releases so if this does fix the issue it will need to be a local patch.

I don't currently have any systems with glibc 2.16 on them or I would.

@Xarthisius
Copy link
Contributor Author

This PR fixes failures with glibc-2.16 and git HEAD. For 2.3.4 I've created separate patch and applied it on distro level[1].
Here's the build log for head: https://gist.github.com/3495957
Information about the system I've used: https://gist.github.com/3495960

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-cluster/slurm/files/slurm-2.3.4-glibc2.16.patch?revision=1.1&view=markup

@dannyauble
Copy link
Member

Thanks for the explanation. I back-ported this to 2.4 (0fad6f5) and merged that into 2.5 outside of this request.

@dannyauble dannyauble closed this Aug 28, 2012
artpol84 added a commit to artpol84/slurm that referenced this pull request May 12, 2017
artpol84 added a commit to artpol84/slurm that referenced this pull request May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants