Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'default_status' and 'allowed_statuses' #7

Closed
wants to merge 1 commit into from
Closed

Add 'default_status' and 'allowed_statuses' #7

wants to merge 1 commit into from

Conversation

trevorld
Copy link

Or you could wait to see if 'pelican' fixes their default status code. Without a fix here or there this plugin won't work.

getpelican/pelican#2558

Or you could wait to see if 'pelican' fixes their default status code.  Without a fix here or there this plugin won't work.

getpelican/pelican#2558
@MinchinWeb
Copy link
Contributor

Would love to see this merged :)

MinchinWeb added a commit to MinchinWeb/blog.minchin.ca that referenced this pull request Aug 19, 2019
Except Pelican. Pelican v4 requires an update to pelican-comment-system. See Scheirle/pelican_comment_system#8
& Scheirle/pelican_comment_system#7
@justinmayer
Copy link
Contributor

@MinchinWeb: If you want, you could submit a PR to address the issue upstream in Pelican itself, as I noted in a comment last month.

@MinchinWeb
Copy link
Contributor

@justinmayer : Pull Request (pelican#2609) has been created! Also, I cleaned up a few failing-on-Windows tests (pelican#2609). As well, I have two languishing pull requests: pelican#2431 that standardizes how paths in settings are built, and pelican#2428 that adds Windows testing to Travis-CI; can you let me know what's needed to move these last two along? Thanks!

@Scheirle : Even with these pull requests submitted to Pelican, I think it would still be worthwhile to merge this one too.

@justinmayer
Copy link
Contributor

Thanks to @MinchinWeb, the fix for this issue has been merged upstream and has been automatically published as Pelican 4.1.1, courtesy of AutoPub. ✨

@trevorld trevorld closed this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants