Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *meltano.yml for Meltano project definitions #2020

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add *meltano.yml for Meltano project definitions #2020

merged 1 commit into from
Jan 13, 2022

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Jan 13, 2022

This is ready for review.

Self-hosting schemas

If you wish to retain full control over your schema definition, simply register it in the schema catalog by providing a url pointing to the self-hosted schema file to the entry.

I think this defines our ideal scenario - since we can control the single source of truth (SSOT) and we can loop together with our own test suite and autoformat configuration.

EDIT: I removed the steps regarding hosting locally within this repo, since it sounds like self-hosting on the Meltano is the better fit.

@aaronsteers aaronsteers marked this pull request as draft January 13, 2022 20:20
@aaronsteers
Copy link
Contributor Author

I think we are leaning towards option 1, in which case this would be ready for review. (To confirm internally.)

@aaronsteers aaronsteers marked this pull request as ready for review January 13, 2022 20:57
@aaronsteers
Copy link
Contributor Author

aaronsteers commented Jan 13, 2022

@madskristensen - You were auto-added as reviewer here. This is our first time adding a schema here, so please let us know if we missed anything. Thanks very much!

@madskristensen madskristensen merged commit 060111a into SchemaStore:master Jan 13, 2022
@madskristensen
Copy link
Contributor

Looks great. Thank you!

@aaronsteers aaronsteers deleted the patch-1 branch January 13, 2022 23:21
@aaronsteers
Copy link
Contributor Author

@madskristensen - This is great, thanks very much!

By chance or from past experience, do you know approximately how long after merging we'd expect to be listed in indexes, and how soon (if not immediate) it would be picked up by VS Code or other editors?

Totally fine if the answer is "it depends" but just wanted to ask so I can set expectations.

Also - we have another schema (our second configuration format) we plan to submit shortly. No action needed but just wanted to give the heads up. 👍

@aaronsteers
Copy link
Contributor Author

It looks like the updates happened within an hour or two! Such an efficient process - thanks again!

@madskristensen
Copy link
Contributor

All the editors are different in how they update the catalog from schemastore. I'm not aware of their individual caching strategies

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Jan 14, 2022

No worries at all. But yeah, it was within an hour or two. (Maybe less but I had to reload VS Code to make it load that schema from the index.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants