-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *meltano.yml for Meltano project definitions #2020
Conversation
I think we are leaning towards option 1, in which case this would be ready for review. (To confirm internally.) |
@madskristensen - You were auto-added as reviewer here. This is our first time adding a schema here, so please let us know if we missed anything. Thanks very much! |
Looks great. Thank you! |
@madskristensen - This is great, thanks very much! By chance or from past experience, do you know approximately how long after merging we'd expect to be listed in indexes, and how soon (if not immediate) it would be picked up by VS Code or other editors? Totally fine if the answer is "it depends" but just wanted to ask so I can set expectations. Also - we have another schema (our second configuration format) we plan to submit shortly. No action needed but just wanted to give the heads up. 👍 |
It looks like the updates happened within an hour or two! Such an efficient process - thanks again! |
All the editors are different in how they update the catalog from schemastore. I'm not aware of their individual caching strategies |
No worries at all. But yeah, it was within an hour or two. (Maybe less but I had to reload VS Code to make it load that schema from the index.) |
This is ready for review.
I think this defines our ideal scenario - since we can control the single source of truth (SSOT) and we can loop together with our own test suite and autoformat configuration.
EDIT: I removed the steps regarding hosting locally within this repo, since it sounds like self-hosting on the Meltano is the better fit.