Partial support Cargo Workspace Inheritance #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
|
@madskristensen Hi, the PR is ready for review, thanks! The change seems large, I'm not sure should we let someone from Cargo team to review that, but it works well for the test files. |
|
Thanks |
jmatias
pushed a commit
to jmatias/schemastore
that referenced
this pull request
Sep 20, 2022
* Partial support Cargo Workspace Inheritance Signed-off-by: TennyZhuang <zty0826@gmail.com> * fix a typo Signed-off-by: TennyZhuang <zty0826@gmail.com> * fix a bug Signed-off-by: TennyZhuang <zty0826@gmail.com> * add all fields support Signed-off-by: TennyZhuang <zty0826@gmail.com> * add some tests Signed-off-by: TennyZhuang <zty0826@gmail.com> Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang zty0826@gmail.com
Add partial support for Cargo Workspace Inheritance.
The PR doesn't contains the part
workspace.dependencies, I will add the support later.