Format JavaScript, CSS, and Markdown with Prettier #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
hyperupcall
force-pushed
the
pre-commit-add-more-files
branch
3 times, most recently
from
aed9a41
to
4b5d7c6
Compare
hyperupcall
force-pushed
the
pre-commit-add-more-files
branch
from
4b5d7c6
to
3935bad
Compare
|
Sorry for the messy force-pushing; I wanted to keep the commits single-purpose but I forgot to add a newline to |
|
Thanks |
|
@hyperupcall |
|
@GerryFerdinandus sure thing - i'll send a PR tomorrow |
jmatias
pushed a commit
to jmatias/schemastore
that referenced
this pull request
Jul 19, 2023
* chore: Add config to format JS, CSS, and Markdown with Prettier * chore: Format files with Prettier * chore: Add Prettier format commit to `.git-blame-ignore-revs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same style as #2255, this adds JavaScript, CSS, and Markdown to be formatted with Prettier (to the
.pre-commit-config.yamlfile). I would have added TOML to the mix, but the prettier plugin is in an alpha state.The
.prettierrc.jsonfile is based off theGruntfile.cjsfile; I wanted to minimize the impact of the change. In doing this, this solves problems I've had with editing the CONTRIBUTING.md or Gruntfile; saving the file no longer formats the file, which would have messed up the diff.The first commit adds the config; the second runs Prettier, and the third edits the
.git-blame-ignore-revsfile