Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for Bleep #3269

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Add schema for Bleep #3269

merged 5 commits into from
Sep 29, 2023

Conversation

sideeffffect
Copy link
Contributor

/cc @oyvindberg @jaacko-torus

@sideeffffect
Copy link
Contributor Author

@madskristensen could you please help me understand what I'm doing wrong here?

################ Error message
>> Schema file name must be present in the catalog URL.
>> bleep.json must be present in src/api/json/catalog.json
##############################
Warning: See error message above this line. Use --force to continue.

The newly added section for Bleep looks just like the others around it.

@hyperupcall
Copy link
Collaborator

@sideeffffect Each entry in the catalog.json can have a url that points to either an external schema or an "internal" one. External ones are like the ones you added, and for those, you don't have to add a file for them under src/schemas/json. See this section in the CONTRIBUTING for details

@hyperupcall
Copy link
Collaborator

hyperupcall commented Sep 28, 2023

The actual error you get is because you added a file called src/schemas/json/bleep.json - our build script expects that there is some entry in catalog.json with the url https://json.schemastore.org/bleep.json. We check for that because it doesn't make sense to add a JSON Schema to this repository, but not "export it" through that URL

@hyperupcall
Copy link
Collaborator

thanks!

@hyperupcall hyperupcall merged commit 1b4fa1e into SchemaStore:master Sep 29, 2023
2 of 3 checks passed
@sideeffffect sideeffffect deleted the bleep branch October 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants