Change .msh vertex colour ordering to BGRA. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes it to BGRA which is the expected ordering by Zero Editor and modelmunge.
|
Thanks for the fix! Strange that no one noticed (or reported) that before. Could you increment the last number (sort of like a build number) in xsizet.ver? That should be enough to make it pop up as an update. Then I can merge and do a "release". |
|
Done! Just let me know if anything else needs changing. |
|
All good. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ordering of colour channels in the packed integer for vertex colours to BGRA from RGBA. Making this changes fixes the R and B channels appearing mismatched ingame and in Zero Editor. I am unsure how your versioning and update system works so I have left xsizet.ver alone, if you do need me to update it to some value in order to accept this PR let me know.
A few screenshots to show what this PR fixes.
A simple painted sphere in XSI.
The same sphere exported and put in Zero Editor without the fix (ingame would give the same result).
Again in Zero Editor with the fix.
