Infer shells automatically, and use versions based on the current working directory (optional)
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schniz
force-pushed
the
add-use-on-cd
branch
from
2a596c4
to
e10c50c
Compare
Schniz
commented
Feb 26, 2019
|
|
||
| alias cd=__fnmcd | ||
| |} | ||
| | Fish => {| |
There was a problem hiding this comment.
Hey @elliottsj! do you want to take a look? I know it works - but do you think this is a good way to do it on fish?
There was a problem hiding this comment.
Looks good to me! It's a little beyond my expertise, but from a cursory Google search, --on-variable PWD seems like a great way to do this.
Schniz
force-pushed
the
add-use-on-cd
branch
from
25fd17c
to
628e2b8
Compare
elliottsj
approved these changes
Feb 26, 2019
|
|
||
| alias cd=__fnmcd | ||
| |} | ||
| | Fish => {| |
There was a problem hiding this comment.
Looks good to me! It's a little beyond my expertise, but from a cursory Google search, --on-variable PWD seems like a great way to do this.
Schniz
changed the title
use versions based on the current working directory (optional)use versions based on the current working directory (optional)
* Add the ability to `use` on every pwd change (bash, zsh) * infers shell type automatically. Fixes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to
useon every pwd change (bash, zsh). Also, infers shell type automatically. Fixes #20Thanks @yardnsm for the
zshsnippet!Note: in order to use it, everyone who uses fnm needs to add double-quotes around the "env":
for Fish we moved to use
sourceinstead ofeval: