flexible config.py #146
flexible config.py #146
Conversation
still must add path to config.py
# Conflicts: # genologics/config.py
|
|
||
| # First config file found wins | ||
| config_file = conf_file[0] | ||
| print(config_file) |
|
I understand the idea behind the change, and since it does not break backwards compatibility, I don't have any strong arguments against this PR. |
|
Yes, I see what you mean. Statement in the docstring was from a previous version that wasn't backwards compatible; should've cleaned it up a bit more before the pull request. See changes. |
|
|
||
| Alternate Usage: | ||
| from genologics import config | ||
| BASEURI, USERNAME, PASSWORD, VERSION, MAIN_LOG = load_config(specified_config = <path to config file>) |
There was a problem hiding this comment.
Don't you mean
BASEURI, USERNAME, PASSWORD, VERSION, MAIN_LOG = config.load_config(specified_config = <path to config file>) ?
By using from genologics import config , you only get config in the namespace, not all the declared functions.
|
yes, you're right. |
|
Okay, this looks good. Next question is, do you want this to be integrated in the pip package ? If so, we need to update the version. |
|
Hi, So, the alternative is that it can wait until they do their own regular integration into pip? Otherwise, you have to install using setup.py? This might be beyond my feeble python skills. Cheers,
Ben Tupper |
|
So yes, if it's possible to integrate it into the pip package, that'd be most useful for us. Thanks! |
|
Sure thing. Once this is done, I'll merge and forward the update to pip. |
|
Perfect. |
|
https://pypi.python.org/pypi/genologics has been updated. |
More flexibility in config.py for designation of config file.