Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup DSL generated expression for readability #1024

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Aug 14, 2024

This introduces a bunch of intermediate variables to store inputs to make_ReactionSystem_internal, with the goal of making the generated expression easier to read when debugging. It also makes the creation of t the first thing in the generated code, which should be a first step to allowing time-dependent parameters (something MTK is working on better supporting).

@TorkelE
Copy link
Member

TorkelE commented Aug 15, 2024

Looks good.

Ideally I'd prefer to not do any non-required changes to the DSL file until after #985 is merged (I've already had to do one messy merge thing to get that one back functioning with master). The removing Catalyst. things might work with a simple merge, but not sure about the other changes. If you thing there won't be any problems then feel free to merge, but otherwise I wouldn't might waiting until #985 (with neither of these being very urgent)

@isaacsas isaacsas merged commit c1c6e75 into SciML:master Aug 21, 2024
3 of 4 checks passed
@isaacsas isaacsas deleted the add_dsl_temp_variables_for_readability branch August 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants