Use DiffEqProblemLibrary and add tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of commenting them out, can you add |
|
Ah I didn't know about |
|
Tests work locally, but will fail on Travis etc because there is no release of |
|
Got it. I'll just tag that right now. |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 78.04% 78.04%
=======================================
Files 8 8
Lines 164 164
=======================================
Hits 128 128
Misses 36 36Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Already shortly after SciML/DiffEqProblemLibrary.jl#9 was merged I wanted to open this PR in order to use
DiffEqProblemLibrary.jlin the tests. However, by adding some additional tests I discovered that the unconstrained algorithm computes different solutions for in-place and not in-place functions. I tried to fix this problem, but without success yet. I'll open an issue regarding this problem, the failing tests are commented out in this PR.