Skip to content

Add some DDE problems from DelayDiffEq.jl #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Add some DDE problems from DelayDiffEq.jl #9

merged 1 commit into from
Jul 9, 2017

Conversation

devmotion
Copy link
Member

Hi!

I discovered that the analytical solution to one of the test problems in DelayDiffEq.jl is incorrect. The errors in https://github.com/JuliaDiffEq/DelayDiffEq.jl/blob/master/test/constrained.jl#L32 and https://github.com/JuliaDiffEq/DelayDiffEq.jl/blob/master/test/constrained.jl#L81 do not affect the calculations since they occur outside of the time interval of the corresponding DDE problems. Nevertheless, I thought it could be beneficial to add the most used test problems in DelayDiffEq.jl to this repository, in order to remove redundancy and possible additional errors.

I recalculated both analytical solutions in https://github.com/JuliaDiffEq/DelayDiffEq.jl/blob/master/test/constrained.jl with Mathematica.

@ChrisRackauckas
Copy link
Member

Nice. I've been meaning to get around to this. Thanks for catching that error as well!

@coveralls
Copy link

coveralls commented Jul 9, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling 1c8f176 on devmotion:dde_problems into ae76320 on JuliaDiffEq:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 1c8f176 on devmotion:dde_problems into ae76320 on JuliaDiffEq:master.

@ChrisRackauckas ChrisRackauckas merged commit d60400b into SciML:master Jul 9, 2017
@codecov-io
Copy link

codecov-io commented Jul 9, 2017

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master    #9   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           5     6    +1     
  Lines         142   210   +68     
====================================
- Misses        142   210   +68
Impacted Files Coverage Δ
src/dde_premade_problems.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae76320...1c8f176. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants