Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the double pendulum example #79

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

DominicDams
Copy link
Contributor

@DominicDams DominicDams commented Jan 28, 2024

Prior to this fix the double pendulum example lists p0 and q0 in the wrong order. This doesn't cause the functionality to fail as p0=q0 in the example, but it does cause it to be misleading, as someone looking at the example (like myself) can accidentally end up using the wrong way when they write code based on this example code.

Checklist

  • Appropriate tests were added - no tests were needed
  • Any code changes were done in a way that does not break public API - this is not a public API and makes no change to the actual code
  • All documentation related to code changes were updated - this change makes the example match the actual functionality
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC. - Didn't check this but I changed two letters so hopefully it's fine
  • Any new documentation only uses public API - no new documentation

Additional context

This caused an issue when working on my graduate mechanics homework :(

…tent with how HamiltonianProblem actually works
@ChrisRackauckas ChrisRackauckas merged commit a953204 into SciML:master Feb 2, 2024
@DominicDams DominicDams deleted the FixExample branch February 2, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants