Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up bracketing for spatial solvers. #345

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Set up bracketing for spatial solvers. #345

merged 3 commits into from
Sep 12, 2023

Conversation

Vilin97
Copy link
Contributor

@Vilin97 Vilin97 commented Sep 10, 2023

This is in preparation for the spatial SSA RSSACRDirect.

This is in preparation for the spatial SSA RSSACRDirect.
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have RSSA/RSSACR store the high/low values together in general? i.e. is it likely that whenever we need high we may shortly thereafter need low, and so should just return both? I wonder if that might give a perf bump by storing them together in memory.

@Vilin97
Copy link
Contributor Author

Vilin97 commented Sep 10, 2023

I do like the little handy LowHigh struct. It makes RSSA code look similar to normal code, which is good for maintainability. I'm not sure about performance, that would need to be measured. My instinct is that we would not win much performance by switching non-spatial RSSA-based SSAs to LowHigh.

@coveralls
Copy link

coveralls commented Sep 10, 2023

Pull Request Test Coverage Report for Build 6138963328

  • 24 of 29 (82.76%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/spatial/bracketing.jl 20 25 80.0%
Totals Coverage Status
Change from base Build 6133295964: -0.05%
Covered Lines: 2299
Relevant Lines: 2559

💛 - Coveralls

@Vilin97 Vilin97 merged commit d668f78 into master Sep 12, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants