WIP adjoint #126
Closed
WIP adjoint #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2192146140
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 59.20% 59.24% +0.03%
==========================================
Files 11 11
Lines 603 606 +3
==========================================
+ Hits 357 359 +2
- Misses 246 247 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Comment on lines
+99
to
+101
| if solve_adjoint & !(alg isa Union{AbstractFactorization, | ||
| AbstractSolveFunction}) | ||
| A = A' |
There was a problem hiding this comment.
Why exclude? It should be done for all algs?
Comment on lines
+14
to
+16
| fact = cache.solve_adjoint ? cache.cacheval' : cache.cacheval | ||
|
|
||
| y = _ldiv!(cache.u, fact, cache.b) |
There was a problem hiding this comment.
why adjoint the factorization object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #92