Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returncodes and stats for iterative solvers #508

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

termi-official
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Trying to resolve #507 . However, this is technically a breaking change.

Also, the factorization solvers should set their retcode to Success and not to Default, or am I missing something? Because SciMLBase.successful_retcode(ReturnCode.Default) == false .

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.57%. Comparing base (175a74f) to head (2e44544).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #508       +/-   ##
===========================================
- Coverage   62.61%   24.57%   -38.05%     
===========================================
  Files          29       29               
  Lines        2247     2238        -9     
===========================================
- Hits         1407      550      -857     
- Misses        840     1688      +848     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Test failure is just some tolerance thing in adjoints, will merge.

@ChrisRackauckas ChrisRackauckas merged commit 765985d into SciML:main Jun 6, 2024
12 of 16 checks passed
@termi-official termi-official deleted the do/retcodes branch June 6, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retcode not correctly set
2 participants