Merge pull request #42 from ven-k/patch-1

Bump compat entry for SpecialFunctions to v2 (while keeping the existing v1.3)
SciML · Jun 7, 2022 · ddbf2d6 · ddbf2d6
2 parents 528d62c + 0f52bb1
commit ddbf2d6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "MathML"
 uuid = "abcecc63-2b08-419c-80c4-c63dca6fa478"
 authors = ["anand <anandj@uchicago.edu> and contributors"]
-version = "0.1.10"
+version = "0.1.11"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
@@ -17,7 +17,7 @@ AbstractTrees = "0.3"
 DocStringExtensions = "0.8"
 EzXML = "1.1"
 IfElse = "0.1"
-SpecialFunctions = "1.3"
+SpecialFunctions = "1.3, 2"
 Symbolics = "3, 4"
 julia = "1.6"
 

diff --git a/src/MathML.jl b/src/MathML.jl
@@ -5,6 +5,7 @@ module MathML
 using DocStringExtensions
 
 using EzXML, Symbolics, Statistics, IfElse, AbstractTrees
+import SpecialFunctions
 
 include("utils.jl")
 include("parse.jl")

diff --git a/src/maps.jl b/src/maps.jl
@@ -29,7 +29,7 @@ applymap = Dict{String,Function}(
     # "gt" => x -> Base.foldl(Base.:>, x),
 
     # "quotient" => x->Base.:div(x...), # broken, RoundingMode
-    "factorial" => x -> Base.factorial(x...),
+    "factorial" => x -> SpecialFunctions.gamma(1 .+ x[1]),
     "max" => x -> Base.max(x...),
     "min" => x -> Base.min(x...),
     "rem" => x -> Base.:rem(x...),

diff --git a/test/parse.jl b/test/parse.jl
@@ -105,7 +105,7 @@ str = """
 
 # factorial
 str = "<apply><factorial/><ci>x</ci></apply>"
-@test isequal(MathML.parse_str(str), factorial(x))
+@test isequal(MathML.parse_str(str), SpecialFunctions.gamma(1+x))
 
 str = "<apply><factorial/><cn>5</cn></apply>"
 @test MathML.parse_str(str) == 120