Bump compat entry for SpecialFunctions to v2 (while keeping the existing v1.3) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail due to JuliaMath/SpecialFunctions.jl#297 |
ven-k
changed the title
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 64.10% 64.10%
=======================================
Files 4 4
Lines 156 156
=======================================
Hits 100 100
Misses 56 56
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Pull Request Test Coverage Report for Build 2455197958
💛 - Coveralls |
|
wait why did the factorial definition need to change though? |
|
Because it was type piracy of Base. Factorial is only for integers, gamma is for floats, and it seems like this parses into floats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.