If filename has not been created before we have to pass force=true #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, wrt the filename being dangerous, this was not intended to be public but still. |
|
I think a more specific filename will do. With the random hash, we may start to accumulate files |
|
Alright looks good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 35 35
Lines 1685 1685
=======================================
Hits 1356 1356
Misses 329 329
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rm(filename)may be a bit dangerous anyways for a generic defaultfilename="code.jl"