Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.9 to dodge compat bump bandwagon #776

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

AstitvaAggarwal
Copy link
Contributor

@AstitvaAggarwal AstitvaAggarwal commented Dec 30, 2023

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AstitvaAggarwal
Copy link
Contributor Author

@ChrisRackauckas this pr is required for the major pr's merging

@ChrisRackauckas
Copy link
Member

It looks like NNODE is still failing?

@ChrisRackauckas ChrisRackauckas merged commit 9f191f8 into SciML:master Dec 31, 2023
9 of 11 checks passed
@AstitvaAggarwal
Copy link
Contributor Author

AstitvaAggarwal commented Dec 31, 2023

Yeah, noticed that in the BPINN pde pr as well, it seems unrelated to pr, I'll investigate that further and see if tests need to be revised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants