-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robust Singular Jacobian Handling #414
Conversation
With this PR all of the following work: using NonlinearSolve, LinearSolve
function nlls!(du, u, p)
du[1] = 2u[1] - 2
du[2] = (u[1] - 4u[2])^2 + 0.1
du[3] = 0
end
u0 = [0.0, 0.0]
prob = NonlinearLeastSquaresProblem(
NonlinearFunction(nlls!, resid_prototype = zeros(3)), u0)
solve(prob)
solve(prob, GaussNewton(; linsolve = QRFactorization()))
solve(prob, GaussNewton(; linsolve = LUFactorization())) I always display a warning rn, but I will configure the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 86.77% 86.34% -0.44%
==========================================
Files 46 47 +1
Lines 2851 2914 +63
==========================================
+ Hits 2474 2516 +42
- Misses 377 398 +21 ☔ View full report in Codecov by Sentry. |
10528b7
to
dd4a2fb
Compare
Needs SciML/LinearSolve.jl#494 before the tests pass |
ab8a5e4
to
b2a2316
Compare
@ChrisRackauckas do you have a suggestion on how to deal with this
Apart for this, we are good to go here. Okay maybe we can use |
7ac1298
to
d125c7e
Compare
d125c7e
to
914f556
Compare
Current approach is:
TODOs
verbose
to turn off printing@ChrisRackauckas any idea how to handle this last part?