-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NonlinearSolveBase
+ BracketingNonlinearSolve
+ SimpleNonlinearSolve
#458
base: master
Are you sure you want to change the base?
Conversation
@time begin
using SimpleNonlinearSolve
prob_brack = IntervalNonlinearProblem{false}(
(u, p) -> u^2 - p, (0.0, 25.0), 5)
solve(prob_brack, ITP())
end
# 1.574422 seconds (1.17 M allocations: 81.038 MiB, 2.57% gc time, 6.58% compilation time)
@time begin
using BracketingNonlinearSolve, SciMLBase
prob_brack = IntervalNonlinearProblem{false}(
(u, p) -> u^2 - p, (0.0, 25.0), 5)
solve(prob_brack, ITP())
end
# 0.504557 seconds (429.92 k allocations: 30.137 MiB, 6.16% gc time, 25.34% compilation time) |
NonlinearSolveBase
+ BracketingNonlinearSolve
+ SimpleNonlinearSolve
Should we move the DiffEqBase/solve.jl to SciMLBase? We probably should and make that a bit more generic, and then reuse it in more contexts anyways. |
You also want the diffeqbase.jl functionwrappers though. |
I think so. They don't seem to be diffeq specific.
Not sure what you are referring to |
First step in cutting down on load times. This is mostly independent of #456
DiffEqBase
toNonlinearSolveBase
in theSimple
packages.SimpleNonlinearSolve
into (SimpleNonlinearSolve
has longer load times thanLux
which sounds extremely wrong)SimpleNonlinearSolve
-- retains its current functionality but drops DiffEqBase and loads NonlinearSolveBase and BracketingNonlinearSolveBracketingNonlinearSolve
NonlinearSolveBase
have?get_concrete_problem
There's a bunch of stuff in NonlinearSolve that can eventually be moved into base, but that is something to do later on.
Tasklist