Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove early defaulting and fix factorization algs #2052

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Remove early defaulting and fix factorization algs #2052

merged 1 commit into from
Nov 6, 2023

Commits on Nov 5, 2023

  1. Remove early defaulting and fix factorization algs 

    No longer default to GMRES on SplitODEProblem when it's not an operator equation. LUFactorization works fine. GenericFactorization has stronger assumptions than is required.

This removes the early defaulting since `linsolve=nothing` is type-inferrable for defaultalg since it's a single algorithm, and thus doing it early has no benefit but significant drawbacks. One drawback case is Radau since it picks the default based on real numbers but requires complex numbers. This is also the reason for the aforementioned factorization issue on SplitODEProblem, it was simply choosing wrong.
    @ChrisRackauckas
    ChrisRackauckas committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    a8c5f45 View commit details
    Browse the repository at this point in the history