Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Rodas5P dense output for non Array inplace #2244

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented Jun 10, 2024

fixes #2242
I really don't like the fact that we have custom methods for Array since they dramatically increase the risk of untested typos in the case of inplace with non-array types. We really should be testing to see if we can delete these cases.

@oscardssmith oscardssmith changed the title fix Rodas5P dense output for non Array inplace fix Rodas5P dense output for non Array inplace Jun 10, 2024
@oscardssmith
Copy link
Contributor Author

I'm very unsure whether this second commit is good or not, but it removes the specialized <:Array implimentations for _ode_addsteps! of Rosenbrock matrices on the theory that most of the time should be in the linearsolve, and the broadcasted versions should be fast anyway. This significantly reduces the risk of future bugs of this type by making it so the in place array code and in place non-array code are identical.

@oscardssmith
Copy link
Contributor Author

if the second commit here is ok, this is good to merge.

@ChrisRackauckas ChrisRackauckas merged commit bff83a7 into SciML:master Jun 11, 2024
29 of 33 checks passed
@oscardssmith oscardssmith deleted the os/fix-Rodas5P-addsteps branch June 11, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: UndefVarError: a71 not defined when using Rodas5P with ContinuousCallback
2 participants