Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lazy caches support get_tmp #102

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Feb 10, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@LilithHafner
Copy link
Member Author

Motivated by DARPA-ASKEM/sciml-service#141, this facilitates seamlessly switching from DiffCache to LazyBufferCache without changing get_tmp calls to getindex calls. I'm not sure what the point of the get_tmp(dc, u) = dc method is, and someone who does know why that method exists should confirm that providing a more specific method here does not break anything.

@ChrisRackauckas ChrisRackauckas merged commit 1358905 into SciML:master Feb 11, 2024
15 checks passed
@LilithHafner LilithHafner deleted the lh/lazy-get-tmp branch February 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants