Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move literal_getproperty adjoint to SciMLSensitivity #1056

Merged
merged 4 commits into from
May 26, 2024

Conversation

DhairyaLGandhi
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi commented May 21, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Moves the literal_getproperty from SciMLBase to here to make it easier to remove in the future in favour of structural tangents. These are necessary to make it possible to accumulate gradients against parameters.

Add any other context about the problem here.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.43%. Comparing base (08c0f94) to head (ac2f59a).
Report is 13 commits behind head on master.

Files Patch % Lines
src/adjoint_common.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1056       +/-   ##
===========================================
+ Coverage    0.00%   58.43%   +58.43%     
===========================================
  Files          18       19        +1     
  Lines        4487     4538       +51     
===========================================
+ Hits            0     2652     +2652     
+ Misses       4487     1886     -2601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaLGandhi DhairyaLGandhi changed the title chore: move literal_getproperty here chore: move literal_getproperty adjoint to SciMLSensitivity May 23, 2024
@ChrisRackauckas ChrisRackauckas merged commit dbb5917 into master May 26, 2024
16 of 19 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dg/literal branch May 26, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants