Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to JuliaLang/julia#42125 #16

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

simeonschaub
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #16 (e3e240c) into master (9a8c427) will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files           7        7           
  Lines         421      421           
=======================================
  Hits          414      414           
  Misses          7        7           
Impacted Files Coverage Δ
src/Static.jl 97.77% <92.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8c427...e3e240c. Read the comment docs.

@chriselrod chriselrod merged commit 27ccdee into SciML:master Sep 10, 2021
@simeonschaub simeonschaub deleted the sds/fix_constprop branch September 10, 2021 18:23
@simeonschaub
Copy link
Contributor Author

That was quick, thanks!

@simeonschaub
Copy link
Contributor Author

Would you mind tagging a new release as well?

@mcabbott
Copy link

Well done, was about to make an issue.

Seems that ArrayInterface.jl fails not just because of this dependency, but also by itself:

https://github.com/JuliaArrays/ArrayInterface.jl/blob/5699c53c6d4d8c0b421b1044e280484a1e9a15a3/src/ArrayInterface.jl#L17

@simeonschaub
Copy link
Contributor Author

Good catch! I made another PR here: JuliaArrays/ArrayInterface.jl#204

@chriselrod
Copy link
Collaborator

Would you mind tagging a new release as well?

Thanks for the PR!
Released as 0.3.2.

@MasonProtter
Copy link

This breaks in Julia v1.7.0-beta4. The version bounds used are not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants