Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode version for @constprop #18

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

simeonschaub
Copy link
Contributor

@simeonschaub simeonschaub commented Sep 10, 2021

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #18 (3f61d83) into master (9922cae) will decrease coverage by 6.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   98.33%   91.90%   -6.44%     
==========================================
  Files           7        7              
  Lines         421      383      -38     
==========================================
- Hits          414      352      -62     
- Misses          7       31      +24     
Impacted Files Coverage Δ
src/Static.jl 83.33% <ø> (-14.45%) ⬇️
src/ndindex.jl 80.32% <0.00%> (-12.73%) ⬇️
src/tuples.jl 92.00% <0.00%> (-8.00%) ⬇️
src/int.jl 95.18% <0.00%> (-4.82%) ⬇️
src/float.jl 94.20% <0.00%> (-4.45%) ⬇️
src/bool.jl 97.84% <0.00%> (-2.16%) ⬇️
src/symbol.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9922cae...3f61d83. Read the comment docs.

@mcabbott
Copy link

Closes #17, I think

@simeonschaub
Copy link
Contributor Author

Yup

@chriselrod
Copy link
Collaborator

Mind bumping the version?

@chriselrod chriselrod merged commit baa9ee4 into SciML:master Sep 10, 2021
@simeonschaub simeonschaub deleted the sds/fix_constprop2 branch September 10, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aggressive_constprop -> @constprop renaming hasn't been backported to 1.7
3 participants