Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quick example and rebuild docs #149

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Update quick example and rebuild docs #149

merged 2 commits into from
Jun 12, 2020

Conversation

mrandri19
Copy link
Contributor

@mrandri19 mrandri19 commented Jun 12, 2020

Update the quick example in the documentation which stopped working after dbb31f9 (kwargs for loba).

Most of the diff is just the docs being rebuilt, the relevant change is: https://github.com/SciML/Surrogates.jl/pull/149/files#diff-493d89206c11fea99259d0771034d26aR103

@ChrisRackauckas
Copy link
Member

The built docs should not be added to master. Let Travis do it on the gh-pages branch

@ChrisRackauckas
Copy link
Member

Oh wait, this repo is a bit messy with that. @ludoro we might want to get that fixed.

@mrandri19
Copy link
Contributor Author

This hopefully should do the trick, I'll check travis' output.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          14       14           
  Lines        1133     1133           
=======================================
  Hits         1013     1013           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fe81c...45848c0. Read the comment docs.

@ludoro
Copy link
Contributor

ludoro commented Jun 12, 2020

Thanks Andrea, I think that the .gitignore should solve the problem mentioned by Chris so I can merge this.

@ludoro ludoro merged commit d606fd5 into SciML:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants