Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the Julia installation #85

Closed
wants to merge 8 commits into from

Conversation

ChrisRackauckas
Copy link
Member

@johnnychen94 is this the right way to check for an existing installation?

@tkf can you help make sure this works correctly with diffeqpy?

@johnnychen94
Copy link

Looks good to me. I guess you'll also need to add jill as the dependency in

install_requires=['julia>=0.2'],

diffeqpy/de.py Outdated Show resolved Hide resolved
diffeqpy/de.py Show resolved Hide resolved
ChrisRackauckas and others added 3 commits January 1, 2021 12:19
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@johnnychen94
Copy link

johnnychen94 commented Jan 1, 2021

I'm not a Python expert so I don't know where the reference is but it seems that the codes(installation) run only when you do import diffeqpy.de and not on import diffeqpy. To make it work, we have to do it in diffeqpy/__init__.py.

Given that jill.py doesn't support quite installation now, probably a better place is to put it in install() and let users trigger it manually?

@ChrisRackauckas
Copy link
Member Author

@tkf set that part up so I'll have to ask for his guidance there.

@ChrisRackauckas
Copy link
Member Author

This automation is now done by JuliaCall

@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch October 10, 2023 21:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants