Feature/add redis config option #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to c81b925
- Looked at
84lines of code in4files - Took 1 minute and 59 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
3additional comments because they didn't meet confidence threshold of50%.
1. r2r/core/providers/logging.py:210:
- Assessed confidence :
0% - Comment:
Good job removing the print statements used for debugging. It's a good practice to not leave them in the production code. - Reasoning:
The print statements in the get_logs function in the logging.py file have been removed. This is a good change as print statements should not be used for debugging in production code.
2. r2r/core/utils/splitter/text.py:149:
- Assessed confidence :
0% - Comment:
Good job renaming the class 'R2RConfig' to 'Config'. It makes the code more consistent and easier to understand. - Reasoning:
The class name 'R2RConfig' has been changed to 'Config' in the text.py file. This seems to be a good change as it makes the code more consistent and easier to understand.
3. r2r/main/app.py:18:
- Assessed confidence :
0% - Comment:
Good job removing the duplicate imports for GenerationConfig and IngestionPipeline. It makes the code cleaner and easier to understand. - Reasoning:
In the app.py file, the imports for GenerationConfig and IngestionPipeline are duplicated. The duplicates have been removed in this PR, which is a good change as it makes the code cleaner and easier to understand.
Workflow ID: wflow_3VDC8JYEY7R33EgF
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| @@ -60,6 +60,22 @@ def load_config(cls, config_path: str = None) -> "R2RConfig": | |||
|
|
|||
| return cls(config_data) | |||
|
|
|||
| # TODO - How to type 'redis.Redis' without introducing dependency on 'redis' package? | |||
| def save_to_redis(self, redis_client: Any, key: str): | |||
There was a problem hiding this comment.
The methods to save and load the configuration from a Redis database are a good addition. However, consider using a more specific type for the 'redis_client' parameter. If introducing a dependency on the 'redis' package is a concern, you could consider using a protocol or interface that specifies the required methods and their signatures, without depending on the specific Redis client implementation.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Mar 15, 2024
* feat: introduce Config class and update E2EPipelineFactory to use it (#172) * add changes * decouple config * Feature/blast web and chat (#173) * add changes * decouple config * blast web and chat * Feature/prompt provider and type reno (#174) * modify * mostly complete. * tweak types * Feature/add app field to config (#175) * modify * mostly complete. * tweak types * fix config name issue, add app field * tweak imports and all that * Feature/add redis config option (#176) * modify * mostly complete. * tweak types * add redis config option * erase cruft * Feature/add redis config option (#177) * modify * mostly complete. * tweak types * add redis config option * erase cruft * update package deps (#178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces the ability to save and load configurations from Redis in the
R2RConfigclass, and includes minor cleanups in other files.Key points:
save_to_redisandload_from_redismethods toR2RConfigclass in/r2r/main/utils.pyfor saving and loading configurations from Redis./r2r/core/providers/logging.py.R2RConfigclass toConfigin/r2r/core/utils/splitter/text.py./r2r/main/app.py.Generated with ❤️ by ellipsis.dev