Feature/blast web and chat #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to a253f14
- Looked at
6760lines of code in107files - Took 6 minutes and 12 seconds to review
More info
- Skipped
49files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_O8p3ZXC2diMKUEJ6
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| @@ -102,22 +95,8 @@ The project includes several basic examples that demonstrate application deploym | |||
| ``` | |||
There was a problem hiding this comment.
The setup instructions for the web and chat applications have been removed. If these instructions are still relevant for users who want to run the applications locally, consider adding them back or providing an alternative location where this information can be found.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Mar 15, 2024
* feat: introduce Config class and update E2EPipelineFactory to use it (#172) * add changes * decouple config * Feature/blast web and chat (#173) * add changes * decouple config * blast web and chat * Feature/prompt provider and type reno (#174) * modify * mostly complete. * tweak types * Feature/add app field to config (#175) * modify * mostly complete. * tweak types * fix config name issue, add app field * tweak imports and all that * Feature/add redis config option (#176) * modify * mostly complete. * tweak types * add redis config option * erase cruft * Feature/add redis config option (#177) * modify * mostly complete. * tweak types * add redis config option * erase cruft * update package deps (#178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes the
webandchatapplications, simplifies the pipeline setup, and removes several components and utilities from the web interface.Key points:
webandchatapplications from the project.r2r/main/factory.pyandr2r/main/utils.py.Embeddings,Footer,IntegrationCard,LocalProvidersMenu,PipelineCard,ProjectHeader,Retrievals,SearchBar,SecretsModal,SubNavigationMenu,ThemeProvider,WorkspacesSelect, and their associated styles.web/src/pages/api.web/src/utils/supabase.Generated with ❤️ by ellipsis.dev