-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/post eval to self #187
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 054b7ed
- Looked at
378
lines of code in5
files - Took 1 minute and 17 seconds to review
More info
- Skipped
1
files when reviewing. - Skipped posting
3
additional comments because they didn't meet confidence threshold of50%
.
1. Dockerfile:2
:
- Assessed confidence :
50%
- Comment:
Consider using a slimmer base image to reduce the Docker image size. If the application doesn't require the full Python image, the slim version could be a better choice.
FROM python:3.9-slim
- Reasoning:
The Dockerfile has been changed to use a non-slim version of Python 3.9. This could potentially increase the size of the Docker image. If the slim version was sufficient for the application's needs, it might be better to stick with it to keep the image size down.
2. Dockerfile:13
:
- Assessed confidence :
50%
- Comment:
Consider removing the verbose mode for poetry install to reduce the log output. If the verbose mode is not necessary, it might be better to remove it.
RUN poetry install -E parsing -E eval --no-interaction --no-ansi
- Reasoning:
The Dockerfile has been changed to use a verbose mode for poetry install. This could potentially increase the log output. If the verbose mode is not necessary, it might be better to remove it to keep the log output minimal.
3. r2r/main/app.py:80
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
Consider making the maximum file size a configurable setting. This would allow for easy adjustments without changing the code.
if file is not None and file.size > config.app('max_file_size_in_mb', default_value) * MB_CONVERSION_FACTOR:
- Reasoning:
The app.py file has a new check for file size during file upload. This is a good practice to prevent large files from being uploaded. However, the maximum file size is hardcoded to 5 MB. It might be better to make this a configurable setting so that it can be easily adjusted without changing the code.
Workflow ID: wflow_jsLUctXTrtBVgNAs
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
|
||
# Example file path for upload | ||
# get file directory | ||
# entry_response = client.add_entry( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the commented out code to improve readability and maintainability of the file. If the commented out code is not necessary, it might be better to remove it.
Summary:
This PR introduces changes in the GitHub workflows, Dockerfile, and Python scripts, including adding a new workflow for building the main branch, renaming an existing workflow, changing the base image in the Dockerfile, modifying the base URL of the API, and adding a file size check in the file upload function.
Key points:
build-main.yml
for building the main branch and triggering templates.publish-to-docker.yml
tobuild-release.yml
.python:3.9-slim
topython:3.9
and simplified the installation command.run_client.py
fromhttp://localhost:8000
tohttp://localhost:8010
and commented out several lines of code.MB_CONVERSION_FACTOR
inapp.py
and added a new condition in theupload_and_process_file
function to check if the file size exceeds the maximum allowed size.Generated with ❤️ by ellipsis.dev