Emrgnt cmplxty patch 1 #253
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to bb4af63
- Looked at
48lines of code in2files - Took 48 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_BYPpzDT5iBV2Msas
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| CMD ["uvicorn", "r2r.examples.basic.app:app", "--host", "0.0.0.0", "--port", "8000", "--workers", "8"] |
There was a problem hiding this comment.
Consider making the number of workers configurable instead of hard-coding it to 8. This can be done by using an environment variable.
| sess.execute(text("create schema if not exists vecs;")) | ||
| except Exception as e: | ||
| if "already exists" not in str(e): | ||
| raise ValueError( |
There was a problem hiding this comment.
Consider raising a more specific exception type or a custom exception instead of ValueError. ValueError is typically used for different kinds of issues.
| raise ValueError( | ||
| f"Error {e} occurred while creating the 'vector' extension." | ||
| ) | ||
|
|
||
| def _supports_hnsw(self): |
There was a problem hiding this comment.
The removal of the line that fetches the 'vector' extension version might cause an AttributeError in the '_supports_hnsw' method. Consider adding it back.
This reverts commit f9420c0.
* Update Dockerfile * Update client.py
This reverts commit f9420c0.
Summary:
This PR enhances the application's performance by enabling multi-worker processes in the Dockerfile and improves error handling in the initialization of the
Clientclass inclient.py.Key points:
/Dockerfileto include--workersflag in CMD command__init__method ofClientclass in/r2r/vecs/client.pyGenerated with ❤️ by ellipsis.dev