-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llms.mdx #322
Merged
Merged
Update llms.mdx #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Reviewed the entire pull request up to 286b500
- Looked at
21
lines of code in1
files - Took 35 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. docs/pages/providers/llms.mdx:89
:
- Assessed confidence :
33%
- Comment:
The change from-E local_llm
to-E local-llm
in the poetry installation command corrects a potential typo or inconsistency. Please ensure this aligns with the actual naming conventions used in thepoetry
configuration or elsewhere in the documentation or codebase. - Reasoning:
The PR modifies the installation command for thellama-cpp-python
package by changing the extra environment flag fromlocal_llm
tolocal-llm
. This change seems to correct a potential typo or inconsistency in the naming convention of the extra environment. However, it's important to verify if this change aligns with the actual naming conventions used in thepoetry
configuration or elsewhere in the documentation or codebase. Iflocal-llm
is indeed the correct term, then this change is valid and improves the clarity and accuracy of the documentation.
Workflow ID: wflow_8HqTvUGe5tdQZkz5
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
* Update local_rag.mdx * Update llms.mdx (#322) * update the default embd. (#310) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
* Update local_rag.mdx * Update llms.mdx (#322) * update the default embd. (#310) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 24, 2024
* update the default embd. (#310) * Feature/add jina reranker rebased (#312) * Add jina reranker * fix oai * Revampt client & server approach. (#316) * Revampt client & server approach. * cleanups * tweak hyde prompt * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/add agent provider rebased v2 (#319) * modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale * Feature/modify get all uniq values (#325) * refine * update * format * fix * Feature/dev merge rebased (#329) * Update local_rag.mdx * Update llms.mdx (#322) * update the default embd. (#310) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge * Feature/fix dev merge mistakes rebased (#330) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge * cleanup * Feature/dev cleanup (#331) * final pub * final pub * json clean * fix sentence transformer issue * include rerank * fix llama cpp * rebase * fix rerank * small tweaks * rollbk config * cleanup
iCUE-Solutions
pushed a commit
to DeweyLearn/DeweyLearnR2R
that referenced
this pull request
Jul 18, 2024
iCUE-Solutions
pushed a commit
to DeweyLearn/DeweyLearnR2R
that referenced
this pull request
Jul 18, 2024
* update the default embd. (SciPhi-AI#310) * Feature/add jina reranker rebased (SciPhi-AI#312) * Add jina reranker * fix oai * Revampt client & server approach. (SciPhi-AI#316) * Revampt client & server approach. * cleanups * tweak hyde prompt * Feature/add agent provider (SciPhi-AI#317) * update pipeline (SciPhi-AI#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/add agent provider rebased v2 (SciPhi-AI#319) * modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale * Feature/modify get all uniq values (SciPhi-AI#325) * refine * update * format * fix * Feature/dev merge rebased (SciPhi-AI#329) * Update local_rag.mdx * Update llms.mdx (SciPhi-AI#322) * update the default embd. (SciPhi-AI#310) * Feature/add agent provider (SciPhi-AI#317) * update pipeline (SciPhi-AI#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (SciPhi-AI#325) * refine * update * format * fix * dev merge * Feature/fix dev merge mistakes rebased (SciPhi-AI#330) * Feature/add agent provider (SciPhi-AI#317) * update pipeline (SciPhi-AI#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (SciPhi-AI#325) * refine * update * format * fix * dev merge * cleanup * Feature/dev cleanup (SciPhi-AI#331) * final pub * final pub * json clean * fix sentence transformer issue * include rerank * fix llama cpp * rebase * fix rerank * small tweaks * rollbk config * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR corrects the poetry install command for
llama-cpp-python
package and adds a newline at the end of thellms.mdx
file.Key points:
llama-cpp-python
package in/docs/pages/providers/llms.mdx
./docs/pages/providers/llms.mdx
.Generated with ❤️ by ellipsis.dev