Feature/add agent provider rebased v2 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 5587007
- Looked at
4001lines of code in68files - Took 1 minute and 36 seconds to review
More info
- Skipped
2files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. r2r/vector_dbs/local/base.py:48:
- Assessed confidence :
66% - Grade:
0% - Comment:
Consider checking if the table already exists before attempting to create it in theinitialize_collectionmethod to optimize database operations and avoid potential errors. - Reasoning:
The code attempts to initialize aLocalVectorDBinstance and set up a SQLite database connection. Theinitialize_collectionmethod is supposed to create a table if it does not exist. However, the method does not check if the table already exists before attempting to create it, which could lead to unnecessary operations or errors if the table already exists. This could be optimized by checking the existence of the table before attempting to create it.
Workflow ID: wflow_7AyyOxHSMoyPgdy4
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
* modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
* modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 23, 2024
* modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale
emrgnt-cmplxty
added a commit
that referenced
this pull request
Apr 24, 2024
* update the default embd. (#310) * Feature/add jina reranker rebased (#312) * Add jina reranker * fix oai * Revampt client & server approach. (#316) * Revampt client & server approach. * cleanups * tweak hyde prompt * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/add agent provider rebased v2 (#319) * modify prompt provider workflow, add agent * fix run qna client * add provider abstraction * tweaks and cleans * move text splitter config locale * Feature/modify get all uniq values (#325) * refine * update * format * fix * Feature/dev merge rebased (#329) * Update local_rag.mdx * Update llms.mdx (#322) * update the default embd. (#310) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge * Feature/fix dev merge mistakes rebased (#330) * Feature/add agent provider (#317) * update pipeline (#315) * Update CONTRIBUTING.md * Delete CONTRIBUTOR.md * Adding agent provider * Feature/modify get all uniq values (#325) * refine * update * format * fix * dev merge * cleanup * Feature/dev cleanup (#331) * final pub * final pub * json clean * fix sentence transformer issue * include rerank * fix llama cpp * rebase * fix rerank * small tweaks * rollbk config * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces significant changes to the R2R project, including the addition of new classes for handling vector entries and search results, updates to provider classes, modifications to the RAG pipeline, and updates to configuration files.
Key points:
VectorEntryandVectorSearchResultinr2r/core/abstractions/vector.pyfor handling vector entries and search results.ProviderConfigandProviderinr2r/core/providers/base.pyas base classes for all providers.r2r/core/providersto inherit from these new base classes and added new provider classes.r2r/core/pipelines/rag.pyto include new parameters in thererank_resultsmethod and updated therunmethod accordingly.r2r/pipelinesfor different use cases.r2r/main/app.pyandr2r/main/factory.pyto use the new provider classes and methods.pyproject.tomlto include new dependencies.r2r/examples/configsto reflect the new structure.Generated with ❤️ by ellipsis.dev