quiet logger

[emrgnt-cmplxty]

🚀	This description was created by Ellipsis for commit 6a83e06

Summary:

Reduced logging verbosity in KVLoggingProvider classes and added a log_run_info flag to the Pipeline class for conditional logging.

Key points:

• Removed initialization log messages from LocalKVLoggingProvider and PostgresKVLoggingProvider constructors in r2r/core/logging/kv_logger.py.
• Added a log message in KVLoggingSingleton.configure method in r2r/core/logging/kv_logger.py.
• Enhanced error logging in KVLoggingSingleton.log method to include log details in r2r/core/logging/kv_logger.py.
• Introduced log_run_info flag in Pipeline class constructor in r2r/core/pipeline/base_pipeline.py.
• Conditional logging of run info based on log_run_info flag in Pipeline.run method in r2r/core/pipeline/base_pipeline.py.
• Set log_run_info=False for nested pipelines in IngestionPipeline.add_pipe method in r2r/core/pipeline/base_pipeline.py.

---

Generated with ❤️ by ellipsis.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
r2r-docs	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 7:12pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 6a83e06 in 52 seconds

More details

• Looked at 100 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. r2r/core/logging/kv_logger.py:64

• Draft comment:
  The removal of initialization logging in individual logging providers and centralizing it in KVLoggingSingleton.configure is a good approach to reduce log redundancy and centralize configuration logging. Ensure that this change aligns with the overall logging strategy of the application.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR removes the initialization logging from the LocalKVLoggingProvider and PostgresKVLoggingProvider constructors. This might reduce the verbosity of logs, which could be the intent given the PR title 'quiet logger'. However, it introduces a new logging statement in the KVLoggingSingleton.configure method, which logs the initialization with the configuration. This change centralizes the logging of initialization to one place, which could be beneficial for maintaining a single point of logging the configuration. The change seems to be consistent across different parts of the code, aiming to reduce redundancy and centralize logging.

2. r2r/core/pipeline/base_pipeline.py:33

• Draft comment:
  The introduction of the log_run_info parameter to control logging at the pipeline level is a thoughtful addition. It allows for better control over logging verbosity, especially in complex setups with nested pipelines. Ensure that all uses of this parameter are intentional and correctly implemented across different pipeline configurations.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR introduces a new parameter log_run_info in the Pipeline constructor to control whether run information should be logged. This is a useful feature for controlling verbosity on a per-pipeline basis. The default value is set to True, which maintains the existing behavior unless explicitly overridden. This change is applied consistently in the run method of the Pipeline class, where it checks the log_run_info flag before logging the run information. Additionally, when creating sub-pipelines for knowledge graph (KG) and embedding within the IngestionPipeline, the log_run_info is explicitly set to False. This could be intended to prevent redundant logging when these pipelines are part of a larger pipeline, which already logs the run information.

Workflow ID: wflow_IkG0EWPqI2qwIuvW

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.