Feature/add kg agent search to pipeline rebased 2 #483
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 62212ba in 2 minutes and 57 seconds
More details
- Looked at
3053lines of code in52files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_R0jUolKqI96dPqfZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ) | ||
|
|
||
| extraction = result.choices[0].message.content | ||
| query = extraction.split("```cypher")[1].split("```")[0] |
There was a problem hiding this comment.
Ensure to strip any leading or trailing whitespace from the extracted query to avoid potential issues during its execution.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7449d1c in 1 minute and 43 seconds
More details
- Looked at
106lines of code in2files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. r2r/main/r2r_client.py:149
- Draft comment:
The PR description mentions the introduction ofKGAgentSearchPipeto replaceKGAgentPipe, but the changes in this PR do not reflect this. Please ensure that the PR description accurately reflects the changes made or update the PR to include the missing changes. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_veoufgAzhSG1HOd9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 89bc9f4 in 2 minutes and 41 seconds
More details
- Looked at
906lines of code in6files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UW7uXaCoSOCs2vLc
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
r2r/main/r2r_client.py
Outdated
| data=serialized_data, | ||
| headers={"Content-Type": "application/json"}, | ||
| ) | ||
| request = R2RUpdateDocumentsRequest(documents=documents, versions=None) |
There was a problem hiding this comment.
suggestion
request = R2RUpdateDocumentsRequest(documents=documents, versions=versions)
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 40744cb in 2 minutes and 45 seconds
More details
- Looked at
1112lines of code in20files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_BOzmC1WOfxdW2CVl
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| metadatas: Optional[list[dict]] = None | ||
|
|
||
|
|
||
| class R2RIngestFilesRequest(BaseModel): |
There was a problem hiding this comment.
The R2RIngestFilesRequest class has inconsistent types for document_ids and user_ids. They are defined as uuid.UUID in the class but are used as strings in various parts of the application. This can lead to type errors or unexpected behavior. Consider aligning the types across all usages.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 46e02f2 in 1 minute and 46 seconds
More details
- Looked at
573lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. r2r/main/r2r_client.py:160
- Draft comment:
The parameter namestreamingshould be updated tostreamto maintain consistency with the rest of the codebase and the PR description.
stream: bool = False,
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_byMa9xGaVfAEikzI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 100f566 in 2 minutes and 6 seconds
More details
- Looked at
174lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_D4VdcUssPqfynpf6
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| class R2RUpdateFilesRequest(BaseModel): | ||
| metadatas: Optional[list[dict]] = None | ||
| document_ids: Optional[uuid.UUID] = None |
There was a problem hiding this comment.
The document_ids field in R2RUpdateFilesRequest should likely be a list of UUIDs to support updating multiple files. Please adjust the type to Optional[list[uuid.UUID]] to align with typical use cases and existing handling logic in the application.
| document_ids: Optional[uuid.UUID] = None | |
| document_ids: Optional[list[uuid.UUID]] = None |
emrgnt-cmplxty
deleted the
feature/add-kg-agent-search-to-pipeline-rebased-2
branch
* expand search pipeline * checkin progress * checkin progress * grinding out * make sure we can configure kg * fix id error on server use * checkin * finish merge, add rag stream * cleanup and pass tests * up * harmonize * check in config refactor * checkin work * cleanup * minor cleanups
* quiet logger (#482) * Add debug mode to Posthog (#480) * Feature/add kg agent search to pipeline rebased 2 (#483) * expand search pipeline * checkin progress * checkin progress * grinding out * make sure we can configure kg * fix id error on server use * checkin * finish merge, add rag stream * cleanup and pass tests * up * harmonize * check in config refactor * checkin work * cleanup * minor cleanups * Add optional metadata to KG cookbook (#484) * Add optional metadata to KG cookbook * Align CB with script * rm cruft and fix bug (#488) * Feature/refactor app logic (#490) * modularize app logic * add management service * add management service * add management service * Feature/move to singleton to prevent reload rebased (#491) * modularize app logic * add management service * prevent r2r reload * prevent r2r reload * add back file (#492) * add back file (#493) * add back file * fix bugs * fix the routes (#496) * rebase * update docs * cleanups --------- Co-authored-by: Nolan Tremelling <34580718+NolanTrem@users.noreply.github.com>
Summary:
Introduced
KGAgentSearchPipe, updatedr2r/main/r2r_client.pyfor streaming, and integrated the new pipe across various components, ensuring backward compatibility while updating specific files and tests.Key points:
KGAgentSearchPipeto replaceKGAgentPipe.r2r/main/r2r_client.pyfor synchronous and asynchronous streaming usingR2RRAGRequest.encode_dataanddecode_datamethods inDocumentclass.r2r/main/r2r_app.py.R2RIngestFilesRequest,R2RUpdateFilesRequest.tests/test_end_to_end.pyandtests/test_server_client.pyto reflect changes.Generated with ❤️ by ellipsis.dev