switch to Kenneth-KT version of google visual r #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that specs pass with new setup but unsure of how to do any further testing |
|
Hi, Thank you for working on it. Rather than switching to new gem, would you like to check the changes and try out that change in the repo itself ? |
| @@ -36,7 +36,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'rubocop' | |||
|
|
|||
| # fetching latest gem from the Gemfile | |||
| spec.add_runtime_dependency 'google_visualr' | |||
| spec.add_runtime_dependency 'google_visualr_rails5' | |||
There was a problem hiding this comment.
Please let us know the what change make it work. So that we get to know if we really need to switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to Kenneth-KT version of google visual r because the old version is broken
References to other Issues or PRs
Fixes #168
Brief description of what is fixed or changed
switch to Kenneth-KT version of google visual r because the old version is broken
Testcase / documentation
switch to Kenneth-KT version of google visual r because the old version is broken
Other comments
Not sure how to test this. I believe this should address the issue though