New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor with RB_TYPE_P #509

Merged

translunar merged 3 commits into SciRuby:master from mrkn:refactor_with_rb_type_p

May 5, 2016

mrkn commented May 5, 2016 •

edited

Loading

In this pull-request, the following refactoring are performed.

Introduce RB_TYPE_P macro (introduced during developing Ruby 1.9.2) and replace simple comparison with TYPE(obj)
Introduce a new IsNMatrixType macro to check whether or not an object is NMatrix
Remove unused macro I found

mrkn added 3 commits

May 5, 2016 12:47


          Refactoring by adding IsNMatrixType

9ba9aa6


          Use RB_TYPE_P instead of simple comparison with TYPE(obj)

2c457b8


          Remove unused macro

mrkn changed the title ~~Refactor with rb type p~~ Refactor with RB_TYPE_P

Member

v0dro commented May 5, 2016

Nice. I particularly like the IsNMatrixType fix.

translunar merged commit d4fa64e into SciRuby:master

mrkn deleted the refactor_with_rb_type_p branch

July 21, 2016 05:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet