New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby port of NMatrix #558

Merged
merged 168 commits into from Feb 3, 2017

Conversation

Projects
None yet
4 participants
@prasunanand

prasunanand commented Dec 16, 2016

rake spec leads to no failure

prasunanand added some commits May 30, 2016

jruby: refactoring the code. nmatrix_java.rb is not in lib/nnatrix di…
…rectory. It gets added in the next commit. nmatrix_test.rb has been deleted permanently. We use existing tests.
jruby: modified jnmatrix.java to store shape as an array and worked o…
…n nmatrix class methods shape, dim , slice ,[] , []= , effective_dimension, is_symmetric, etc.
jruby:initialise of nmatrix changed to improve performance; addition,…
… subtraction, multiplication and division modified accordingly

@prasunanand prasunanand referenced this pull request Dec 16, 2016

Closed

Jruby master #545

prasunanand added some commits Dec 17, 2016

jruby_port: travis script for jruby
jruby_port: travis script2 for jruby

	jruby_port: travis script3 for jruby

jruby_port: remove jruby env from allowed failures
@prasunanand

This comment has been minimized.

Show comment
Hide comment
@prasunanand

prasunanand Dec 24, 2016

Travis tests for JRuby pass and removed from "allowed failures" :) . Please review.

prasunanand commented Dec 24, 2016

Travis tests for JRuby pass and removed from "allowed failures" :) . Please review.

@wlevine

This comment has been minimized.

Show comment
Hide comment
@wlevine

wlevine Jan 17, 2017

One concern: the dtype argument is totally ignored. I understand that currently only doubles are supported, but an error should be thrown if I try to create a matrix with an unsupported dtype. The same with stype. You should refuse to create a matrix if someone specifies an stype other than :dense.

wlevine commented Jan 17, 2017

One concern: the dtype argument is totally ignored. I understand that currently only doubles are supported, but an error should be thrown if I try to create a matrix with an unsupported dtype. The same with stype. You should refuse to create a matrix if someone specifies an stype other than :dense.

@dtype = hash[:dtype]
@stype = hash[:stype]
else
@dtype = :double

This comment has been minimized.

@wlevine

wlevine Jan 17, 2017

This should be :float64 not :double

@wlevine

wlevine Jan 17, 2017

This should be :float64 not :double

This comment has been minimized.

@prasunanand

prasunanand Jan 20, 2017

Yeah. I will correct it.

@prasunanand

prasunanand Jan 20, 2017

Yeah. I will correct it.

This comment has been minimized.

@prasunanand

prasunanand Jan 20, 2017

I am not throwing any error here because a lot of tests will fail in that case. And I assure you that this feature will be properly implemented in next PR.

@prasunanand

prasunanand Jan 20, 2017

I am not throwing any error here because a lot of tests will fail in that case. And I assure you that this feature will be properly implemented in next PR.

@wlevine

This comment has been minimized.

Show comment
Hide comment
@wlevine

wlevine Jan 17, 2017

It seems like rake package is broken on your branch.

wlevine commented Jan 17, 2017

It seems like rake package is broken on your branch.

tar zxvf commons-math3-3.6.1-bin.tar.gz
mkdir ext/nmatrix_java/vendor/
cp commons-math3-3.6.1/commons-math3-3.6.1.jar ext/nmatrix_java/vendor/

This comment has been minimized.

@wlevine

wlevine Jan 17, 2017

Are all these steps still required? It seems like this is already done by the rake task.

Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.

Are you planning to get this to work with a simple gem install?

Also, you should probably add a small note to the README, noting the limited features of the JRuby version.

@wlevine

wlevine Jan 17, 2017

Are all these steps still required? It seems like this is already done by the rake task.

Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.

Are you planning to get this to work with a simple gem install?

Also, you should probably add a small note to the README, noting the limited features of the JRuby version.

This comment has been minimized.

@prasunanand

prasunanand Jan 20, 2017

Are all these steps still required? It seems like this is already done by the rake task.
=> These steps are not done by rake task. And, a rake task can be added to achieve this.

Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.
=> AFAIK, this is the only way.

Are you planning to get this to work with a simple gem install?
=>Yes, It works with gem install

Also, you should probably add a small note to the README, noting the limited features of the JRuby version.
=>Sure

@prasunanand

prasunanand Jan 20, 2017

Are all these steps still required? It seems like this is already done by the rake task.
=> These steps are not done by rake task. And, a rake task can be added to achieve this.

Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.
=> AFAIK, this is the only way.

Are you planning to get this to work with a simple gem install?
=>Yes, It works with gem install

Also, you should probably add a small note to the README, noting the limited features of the JRuby version.
=>Sure

This comment has been minimized.

@prasunanand

prasunanand Jan 20, 2017

There is some error with json-version. I will correct it. I left it earlier, because there was no error with travis tests. So, I thought that the error was limited to my machine only.

@prasunanand

prasunanand Jan 20, 2017

There is some error with json-version. I will correct it. I left it earlier, because there was no error with travis tests. So, I thought that the error was limited to my machine only.

@mohawkjohn mohawkjohn merged commit f5c87a1 into SciRuby:master Feb 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@v0dro

This comment has been minimized.

Show comment
Hide comment
@v0dro

v0dro Feb 9, 2017

Member

Finally this is merged! Congratulations @prasunanand =)

Member

v0dro commented Feb 9, 2017

Finally this is merged! Congratulations @prasunanand =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment