JRuby port of NMatrix #558
Conversation
…rectory. It gets added in the next commit. nmatrix_test.rb has been deleted permanently. We use existing tests.
…n nmatrix class methods shape, dim , slice ,[] , []= , effective_dimension, is_symmetric, etc.
…modulo and few unary operators
… subtraction, multiplication and division modified accordingly
prasunanand
force-pushed
the
jruby_test_rebase
branch
from
53c50e5
to
0eb5fc5
Compare
jruby_port: travis script2 for jruby jruby_port: travis script3 for jruby jruby_port: remove jruby env from allowed failures
prasunanand
force-pushed
the
jruby_test_rebase
branch
from
a6cde08
to
4997f3c
Compare
|
Travis tests for JRuby pass and removed from "allowed failures" :) . Please review. |
|
One concern: the dtype argument is totally ignored. I understand that currently only doubles are supported, but an error should be thrown if I try to create a matrix with an unsupported dtype. The same with stype. You should refuse to create a matrix if someone specifies an stype other than :dense. |
| @dtype = hash[:dtype] | ||
| @stype = hash[:stype] | ||
| else | ||
| @dtype = :double |
There was a problem hiding this comment.
Yeah. I will correct it.
There was a problem hiding this comment.
I am not throwing any error here because a lot of tests will fail in that case. And I assure you that this feature will be properly implemented in next PR.
|
It seems like |
| tar zxvf commons-math3-3.6.1-bin.tar.gz | ||
| mkdir ext/nmatrix_java/vendor/ | ||
| cp commons-math3-3.6.1/commons-math3-3.6.1.jar ext/nmatrix_java/vendor/ | ||
|
|
There was a problem hiding this comment.
Are all these steps still required? It seems like this is already done by the rake task.
Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.
Are you planning to get this to work with a simple gem install?
Also, you should probably add a small note to the README, noting the limited features of the JRuby version.
There was a problem hiding this comment.
Are all these steps still required? It seems like this is already done by the rake task.
=> These steps are not done by rake task. And, a rake task can be added to achieve this.
Also is this the standard way of dealing with Java libraries (just downloading them and sticking the jar in a random directory)? It seems a little unfortunate.
=> AFAIK, this is the only way.
Are you planning to get this to work with a simple gem install?
=>Yes, It works with gem install
Also, you should probably add a small note to the README, noting the limited features of the JRuby version.
=>Sure
There was a problem hiding this comment.
There is some error with json-version. I will correct it. I left it earlier, because there was no error with travis tests. So, I thought that the error was limited to my machine only.
|
Finally this is merged! Congratulations @prasunanand =) |
rake spec leads to no failure