Created #positive_definite? #561
Conversation
|
Can someone also please point out as to why am I receiving a build error with this code. |
From the travis-ci log, it looks like the variable
|
|
Thank you @agisga |
| raise(ShapeError, "positive definite calculated only for square matrices") unless self.dim == 2 && self.shape[0] == self.shape[1] | ||
| ans=true | ||
| cond=0 | ||
| while cond!=self.cols |
There was a problem hiding this comment.
Please adjust if possible to NMatrix coding style.
| @@ -1060,4 +1060,13 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "#positive_definite? for #{dtype}" do | |||
There was a problem hiding this comment.
This is not working because you've added it outside the dtype context block. Please have a closer look at the file structure. You can also test your specs on your own machine by doing bundle exec rake spec.
|
@MohawkJohn I have made changes adhering to the NMatrix coding style, following Github's Ruby Styleguide. |
|
@v0dro Here's another one. This one needs a squash and merge (once you're reviewed it also, of course). |
|
@shardulparab97 : Can I recommend that you open a new issue since #411 has a few other functions listed in its agenda as well? (Since there is also a stalled pull request #461 that was attempting to solve #411 completely this would help keep things a bit saner) Alternatively you could just refer to #461 if you wish to complete the entire function set yourself but this seems perfectly fine too. @v0dro : I'm not sure why #461 was closed by the author because it was as good as complete, with a few changes pending, those were a bunch of simple yet handy functions. |
Pull request in response to #411