Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created #positive_definite? #561

Merged
merged 4 commits into from Mar 22, 2017
Merged

Created #positive_definite? #561

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a75ec6e
Creating positive_definite?
shardulparab97 Jan 6, 2017
78411b5
Spec for #positive_definite?
shardulparab97 Jan 6, 2017
4993050
Few changes
shardulparab97 Jan 6, 2017
3195223
Style changes made
shardulparab97 Jan 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/math_spec.rb
View file
Open in desktop
Expand Up @@ -1060,4 +1060,13 @@
end
end
end

context "#positive_definite? for #{dtype}" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working because you've added it outside the dtype context block. Please have a closer look at the file structure. You can also test your specs on your own machine by doing bundle exec rake spec.

it "should return true for positive_definite? matrix" do
n = NMatrix.new([3,3], [2, -1, -1,
-1, 2, -1,
-1, -1, 3], dtype: dtype)
expect(n.positive_definite?).to be_truthy
end
end
end