Add ne_ prefix to NaturalEarth cache files. #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prefix is used in the zip files provided by NaturalEarth, so if you download anything manually, you need to rename all the files for Cartopy to find them. This change makes that renaming no longer necessary, at the expense of a few extra re-downloads.
pelson
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
This was certainly necessary at one point, but I agree with moving forwards with the new naming scheme.
I have kept promising myself to go back and add versioning into the downloader, so that we can [in]validate old files, and help people avoid a stagnant cache of files.
Glad to see that the tests have passed (a good sign for this PR). Any thoughts on the implications for tools/feature_download.py? It looks to me like the config is being used well in that script, so everything should "just worktm".
pelson
requested changes
Apr 26, 2018
|
Done. |
|
Thanks @QuLogic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefix is used in the zip files provided by NaturalEarth, so if you download anything manually, you need to rename all the files for Cartopy to find them. This change makes that renaming no longer necessary, at the expense of a few extra re-downloads.
I don't know if NE changed the filenames or we have just been messing it up all this time.