Adding a nightshade/terminator feature #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 29, 2018
greglucas
force-pushed
the
terminator_nightshade
branch
from
1575dbe
to
bb3f5d4
Compare
stickler-ci
reviewed
Sep 29, 2018
greglucas
force-pushed
the
terminator_nightshade
branch
from
c68e3d8
to
4304a6b
Compare
QuLogic
reviewed
Oct 29, 2018
lib/cartopy/mpl/solar.py
Outdated
| 0.019994643*np.sin(2*M_sun*deg2rad)) | ||
|
|
||
| # obliquity of the ecliptic (epsilon in Vallado's notation) | ||
| epsilon = 23.439291 - 0.0130042*T_UT1 |
There was a problem hiding this comment.
Use np.deg2rad here so you don't need to convert units twice below.
greglucas
force-pushed
the
terminator_nightshade
branch
from
4304a6b
to
e07c1fc
Compare
|
@QuLogic, thanks for the excellent review. I didn't know a lot of the test features and other standards you pointed out, so I learned something too! I've amended the commit with all of the changes, other than the deg/rad which I replied to above in my thinking. |
QuLogic
approved these changes
Nov 13, 2018
|
Thanks @greglucas! |
|
For the record, I followed this up in #1181 in order to reduce the impact on the GeoAxes namespace, and to keep a clean separation between cartopy functionality and cartopy's matplotlib interface. An example of how to use the nightshade Feature is in that PR, and has been added to the gallery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Adding a nightshade() feature, with refraction to visualize the day/night terminator. This has been requested several times, and I've followed the Aurora example myself numerous times. I blended the Aurora example and old basemap features together for this. I have also implemented refraction/extra daylight hours to be a little more precise.
It addresses the following previous issues: #1038, fixes #1128, follows on from #737.
Implications
I've implemented a solar.py file similar to the one from mpl/basemap to calculate the sun's position in latitude longitude coordinates.
.nightshade() is callable from any geoaxes, let me know if somewhere else would be preferable.